Tests for tiled image map view controller + bugs + docs + zoom. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Re:tiling occasionally missing spots: https://twitter.com/Cocoanetics/status/402690909567221760 |
|
Thread says this is fixed in iOS 7.1. |
|
Yes, travis is not on 7.1 yet. 👍 |
neilang
added a commit
that referenced
this pull request
Mar 14, 2014
Tests for tiled image map view controller + bugs + docs + zoom.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed downloading of tiles that may happen multiple times. In a slow network tiles will take a long time to download, but you may get lots of repaint events. This will cause the queue to get more downloads for the same tiles already being downloaded. We now hold on to a map of URLs to downloads and make sure to only have a single download operation per url running.
Added tests for the tiled image view controller. Notice a missing tile in the snapshot image, this seems to be a bug in iOS (@orta, can you comment with some links, please?).
Zoom will now pan towards the point being tapped. This is really neat and works like any good map would :) All credit is @orta.